deposits: update 'permissions' action method to better handle exception#2027
Open
Lilykos wants to merge 1 commit intocernanalysispreservation:masterfrom
Open
deposits: update 'permissions' action method to better handle exception#2027Lilykos wants to merge 1 commit intocernanalysispreservation:masterfrom
Lilykos wants to merge 1 commit intocernanalysispreservation:masterfrom
Conversation
Lilykos
force-pushed
the
permissions-no-error-msg
branch
from
bf2964b to
c94d4de
Compare
pamfilos
reviewed
Feb 11, 2021
|
|
||
|
|
||
| def test_add_permissions_when_permission_doesnt_exist_returns_400( | ||
| def test_add_permissions_when_permission_doesnt_exist_returns_201( |
Collaborator
There was a problem hiding this comment.
Let's add a test with submitting multiple permissions with one failing to check .rollback
Lilykos
force-pushed
the
permissions-no-error-msg
branch
from
c94d4de to
653f584
Compare
Lilykos
force-pushed
the
permissions-no-error-msg
branch
from
653f584 to
db527f9
Compare
Lilykos
force-pushed
the
permissions-no-error-msg
branch
from
db527f9 to
3ef338e
Compare
* refactors the code so that when an action is not possible, it fails silently, and the flow doesn't stop * closes cernanalysispreservation#2023 Signed-off-by: Ilias Koutsakis <ilias.koutsakis@cern.ch>
Lilykos
force-pushed
the
permissions-no-error-msg
branch
from
3ef338e to
22197a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilias Koutsakis ilias.koutsakis@cern.ch