Public links ORMified

[jessegeens]

The code managing public links was seperated from the code for managing shares up to now. With this PR we change this, and we put the two together.

This was necessary because the old code, which is stored in Reva, still uses the old oc_share table, which means it is not compatible with our new ORMified schemas

[diocas]

We are changing the name of this managers to be called "gorm", right? So I would make this uniform between reva(?)shares and publicshares. An change the folder name.

I would also avoid some duplicate code related to DB opening and such. You can split it and re-use in 2 different places. But the split you did to not have publicshares and reva(?)shares mixed in shares.go is already better.

[jessegeens]

We are changing the name of this managers to be called "gorm", right?

Only for public links, because there is already a sql driver for public links (in reva). I agree that it's a bit inconsistent now, but instead of renaming the sharing driver to gorm too, I am more a fan of ripping out the old public links sql driver from Reva and renaming this one to be a sql driver too, to make it consistent with the rest of Reva

[diocas]

I am more a fan of ripping out the old public links sql driver from Reva and renaming this one to be a sql driver too

I totally agree. If we can do it already, let's do it. If not, making it consistent would be better for now.

[jessegeens]

I am more a fan of ripping out the old public links sql driver from Reva and renaming this one to be a sql driver too

I totally agree. If we can do it already, let's do it. If not, making it consistent would be better for now.

I guess we can already. I will modify the driver here to be called sql then. Will then make a Reva PR; and we can merge this one once the Reva PR is ready

[diocas]

Last sprint!

[diocas]

I promise is the last one...