Conversation
jessegeens
left a comment
There was a problem hiding this comment.
You still ignore expired links in getLinkByToken
39a3d42 to
1b99720
Compare
I left this way because the access to expired links still needs to be denied. |
|
Then I would make that explicit, e.g. with a parameter. In fact, you can use Because the difference by accessing via ID / token may be the case here, but that's not guaranteed. E.g. in |
a218541 to
71483b6
Compare
|
Makes sense. I returned the condition to check if it is expired based on the filter and changed its value when it's called by |
71483b6 to
e870084
Compare
|
Yes, looks good now! |
expired public links are now listed