Skip to content

Limit add / update / remove grant to project admins in project spaces #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessegeens merged 1 commit into from
Dec 10, 2025
Merged

Limit add / update / remove grant to project admins in project spaces #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions storage/eoswrapper/eoswrapper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,39 @@ func (w *wrapper) RestoreRevision(ctx context.Context, ref *provider.Reference,
return w.FSWithListRegexSupport.RestoreRevision(ctx, ref, revisionKey)
}

func (w *wrapper) AddGrant(ctx context.Context, ref *provider.Reference, g *provider.Grant) error {
// AddGrant is only allowed for admins in a project space
if w.isProjectInstance() {
if err := w.userIsProjectMember(ctx, ref, requireAdmin); err != nil {
return errtypes.PermissionDenied("eosfs: deny grant can only be set by project admins")
}
}

return w.FSWithListRegexSupport.AddGrant(ctx, ref, g)
}

func (w *wrapper) UpdateGrant(ctx context.Context, ref *provider.Reference, g *provider.Grant) error {
// UpdateGrant is only allowed for admins in a project space
if w.isProjectInstance() {
if err := w.userIsProjectMember(ctx, ref, requireAdmin); err != nil {
return errtypes.PermissionDenied("eosfs: deny grant can only be set by project admins")
}
}

return w.FSWithListRegexSupport.UpdateGrant(ctx, ref, g)
}

func (w *wrapper) RemoveGrant(ctx context.Context, ref *provider.Reference, g *provider.Grant) error {
// RemoveGrant is only allowed for admins in a project space
if w.isProjectInstance() {
if err := w.userIsProjectMember(ctx, ref, requireAdmin); err != nil {
return errtypes.PermissionDenied("eosfs: deny grant can only be set by project admins")
}
}

return w.FSWithListRegexSupport.RemoveGrant(ctx, ref, g)
}

func (w *wrapper) DenyGrant(ctx context.Context, ref *provider.Reference, g *provider.Grantee) error {
// This is only allowed for project space admins
if w.isProjectInstance() {
Expand Down