This repository was archived by the owner on May 7, 2024. It is now read-only.
Open
Conversation
Contributor
Author
|
|
Contributor
|
I don't think this wording really makes it clearer. We need to state that the Encounters returned per page will be more recent than Encounters on subsequent pages. We need to also be clear that within a page the sorting is not guaranteed. |
daliboz
suggested changes
Jul 14, 2020
Contributor
daliboz
left a comment
daliboz
left a comment
There was a problem hiding this comment.
Same concern as Ben - we need to clarify. Encounter responses will be sorted from newest to oldest page by Encounter.period, though items within a single page may not be sorted.
Contributor
Author
|
Updated screenshot: |
BroadwayBean
approved these changes
Aug 17, 2020
MaxPhilips
approved these changes
Mar 10, 2021
Contributor
MaxPhilips
left a comment
MaxPhilips
left a comment
There was a problem hiding this comment.
+1 if we ditch the second period at the end
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addressing slightly ambiguous verbiage in #381
PR Checklist