Skip to content

Add cnames for domains used by annotations#58

Merged
cert-manager-prow[bot] merged 2 commits intocert-manager:mainfrom
jsoref:docs-annotations-cnames
Jun 12, 2025
Merged

Add cnames for domains used by annotations#58
cert-manager-prow[bot] merged 2 commits intocert-manager:mainfrom
jsoref:docs-annotations-cnames

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Jun 11, 2025

jsoref and others added 2 commits June 11, 2025 16:17
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 11, 2025
@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2025
@inteon
Copy link
Copy Markdown
Member

inteon commented Jun 12, 2025

I applied the terraform & updated the Netlify configuration (added the domain aliases).

@inteon
Copy link
Copy Markdown
Member

inteon commented Jun 12, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2025
@cert-manager-prow cert-manager-prow bot merged commit 2d77f6b into cert-manager:main Jun 12, 2025
2 checks passed
@inteon
Copy link
Copy Markdown
Member

inteon commented Jun 12, 2025

@jsoref jsoref deleted the docs-annotations-cnames branch June 12, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants