-
Notifications
You must be signed in to change notification settings - Fork 95
feat: add toplevel enable value to helmchart #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @FloSchick. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Working together with @FloSchick at Contribfest cert-manager on KubeCon 2025 :-) |
Signed-off-by: FloSchick <[email protected]>
ba223f3
to
f98ad8a
Compare
/ok-to-test |
Thanks! Please run |
/retest |
Also DCO check is failing. Please see https://cert-manager.io/docs/contributing/sign-off/. |
So I think that you need to include "value missing from templates: enabled" in this file. This is because the value is not used in any actual helm template. Our linter calls this out. So we need that string to have it exempt from the linter. I worked that out by checking the cert-manager exemptions here. |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@hawksight thanks for looking into this, i was not able to resolve this on my own. Added the ingore value. |
@FloSchick: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@FloSchick - thank you for your contribution. I created another PR in #680 so that tests passed and commits were signed. This now merged and hopefully will go out in the next release. Thank you for taking a good first stab at the issue! |
Fixes #574. Adds Field that can be used as a condition when cert-manager is a dependency.