Skip to content

Conversation

FloSchick
Copy link

@FloSchick FloSchick commented Apr 2, 2025

Fixes #574. Adds Field that can be used as a condition when cert-manager is a dependency.

@cert-manager-prow cert-manager-prow bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Apr 2, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2025
@cert-manager-prow
Copy link
Contributor

Hi @FloSchick. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 2, 2025
@SBejga
Copy link

SBejga commented Apr 2, 2025

Working together with @FloSchick at Contribfest cert-manager on KubeCon 2025 :-)

@FloSchick FloSchick force-pushed the feat/toplevel-chart-enable branch from ba223f3 to f98ad8a Compare April 2, 2025 14:45
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Apr 2, 2025
@erikgb
Copy link
Member

erikgb commented Apr 3, 2025

/ok-to-test

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 3, 2025
@erikgb
Copy link
Member

erikgb commented Apr 6, 2025

Thanks! Please run make generate-helm-schema and commit the result to fix CI!

@cert-manager-prow cert-manager-prow bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Apr 7, 2025
@hawksight
Copy link
Member

/retest

@erikgb
Copy link
Member

erikgb commented Apr 10, 2025

Could not lint: values.yaml and templates are not in sync

Also DCO check is failing. Please see https://cert-manager.io/docs/contributing/sign-off/.

@hawksight
Copy link
Member

So I think that you need to include "value missing from templates: enabled" in this file.

This is because the value is not used in any actual helm template. Our linter calls this out. So we need that string to have it exempt from the linter. I worked that out by checking the cert-manager exemptions here.

@cert-manager-prow
Copy link
Contributor

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

  • d608ec0 fix ci
  • ce276d1 fix: linter - ignore missing enabled value from templates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@FloSchick
Copy link
Author

@hawksight thanks for looking into this, i was not able to resolve this on my own. Added the ingore value.

@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Apr 15, 2025

@FloSchick: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-trust-manager-test ce276d1 link true /test pull-trust-manager-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2025
@cert-manager-prow
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawksight
Copy link
Member

hawksight commented Aug 11, 2025

@FloSchick - thank you for your contribution. I created another PR in #680 so that tests passed and commits were signed. This now merged and hopefully will go out in the next release. Thank you for taking a good first stab at the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a top level variable called enabled to the Helm chart schema
4 participants