Add generation of applyconfigurations (again)#598
Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom Apr 14, 2025
Merged
Add generation of applyconfigurations (again)#598cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
cert-manager-prow[bot] merged 1 commit intocert-manager:mainfrom
Conversation
cert-manager-prow
bot
added
dco-signoff: yes
Member
Author
|
/test pull-trust-manager-smoke |
inteon
reviewed
Apr 14, 2025
erikgb
force-pushed
the
generate-applyconfigurations
branch
from
2195346 to
07d6a0e
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
generate-applyconfigurations
branch
from
07d6a0e to
3a5ac70
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a remake of #217 - which got lost in some makefile-modules improvements. This has led to outdated applyconfigurations. After this PR is merged, this should be validated by our CI.
While we are not using our applyconfigurations (yet), it seems like others are using it, ref. cert-manager/cert-manager#5783 (comment), so I think we should prefer this PR over #589.
Closes #589