Skip to content

Conversation

jnoordsij
Copy link

The documentation on the preferredChain still mentions the cross-signed version of ISRG Root X1 CA cert from Let's Encrypt, which has expired as of Monday, September 30th, 2024 (see https://letsencrypt.org/2023/07/10/cross-sign-expiration/).

To use a more representative example, I've replaced this with the example from current Let's Encrypt documentation (see https://letsencrypt.org/certificates/#chains).

Note that the wording and example are very much opiniated, so there's a variety of alternative approaches to replacing this example:

  • word differently from what I've now picked
  • remove the example entirely
  • just refer to upstream Let's Encrypt documentation without listing an example, to prevent it from going outdated once more at some point in the future

@cert-manager-prow cert-manager-prow bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Jun 23, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sgtcodfish for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2025
Copy link

netlify bot commented Jun 23, 2025

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 689037b
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/68adaf09f559d10008641979
😎 Deploy Preview https://deploy-preview-1723--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant