Skip to content

Adam found that there is a newline after "10" #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cert-manager-prow merged 2 commits into from
Jan 13, 2026
Merged

Adam found that there is a newline after "10" #1906

cert-manager-prow merged 2 commits into from
Jan 13, 2026

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Jan 6, 2026 •
edited
Loading

Not sure why https://cert-manager.io/docs/contributing/#daily-check-in has this random newline after 10, seems like :30 got rendered as a newline!

issue

Preview: https://deploy-preview-1906--cert-manager.netlify.app/docs/contributing/

Copilot AI review requested due to automatic review settings January 6, 2026 11:14
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 6, 2026
Copilot AI reviewed Jan 6, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a markdown formatting issue where "10:30" was being incorrectly interpreted as an ordered list item, causing an unwanted newline after "10".

  • Escaped the colon in "10:30" within the link text to prevent markdown list interpretation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@netlify
Copy link

netlify bot commented Jan 6, 2026 •
edited
Loading

✅ Deploy Preview for cert-manager ready!

Name Link
🔨 Latest commit 499d3a2
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/6966240628db860008d911e1
😎 Deploy Preview https://deploy-preview-1906--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

maelvls
maelvls commented Jan 6, 2026
View reviewed changes
content/docs/contributing/README.md
### Daily Check-In

Our daily check-in meetings [happen on Zoom](https://zoom-lfx.platform.linuxfoundation.org/meeting/97683894330?password=1cb64ed5-3014-48b6-ae72-3d0738ac2263) at [10:30 London time](http://www.thetimezoneconverter.com/?t=10:30&tz=Europe/London). The exact days for which the standup is happening can be seen on the [calendar page](https://zoom-lfx.platform.linuxfoundation.org/meetings/cert-manager?view=list) and may change.
Our daily check-in meetings [happen on Zoom](https://zoom-lfx.platform.linuxfoundation.org/meeting/97683894330?password=1cb64ed5-3014-48b6-ae72-3d0738ac2263) at [10\:30 London time](http://www.thetimezoneconverter.com/?t=10:30&tz=Europe/London). The exact days for which the standup is happening can be seen on the [calendar page](https://zoom-lfx.platform.linuxfoundation.org/meetings/cert-manager?view=list) and may change.
Copy link
Member Author

@maelvls maelvls Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it renders fine now:

https://deploy-preview-1906--cert-manager.netlify.app/docs/contributing/

@maelvls
Copy link
Member Author

maelvls commented Jan 6, 2026

@ThatsMrTalbot PTAL

@ThatsMrTalbot
Copy link

ThatsMrTalbot commented Jan 6, 2026

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 6, 2026
@ThatsMrTalbot
Copy link

ThatsMrTalbot commented Jan 6, 2026

/hold

Actually found another issue:

image

@cert-manager-prow cert-manager-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2026
@hawksight
Copy link
Member

hawksight commented Jan 6, 2026

/hold

Actually found another issue:
image

@maelvls - can you also correct here?

Adam beat me to it above. I tried to add myself but can't push to branch so probably quicker for you to add :)

@cert-manager-prow cert-manager-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@maelvls
Copy link
Member Author

maelvls commented Jan 13, 2026

Fixed!

hawksight
hawksight reviewed Jan 13, 2026
View reviewed changes
Copy link
Member

@hawksight hawksight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026
@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawksight, ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ThatsMrTalbot,hawksight]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ThatsMrTalbot
Copy link

ThatsMrTalbot commented Jan 13, 2026

/unhold
/lgtm

@cert-manager-prow cert-manager-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026
@cert-manager-prow cert-manager-prow bot merged commit 0d4e237 into master Jan 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@hawksight hawksight hawksight left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@ThatsMrTalbot ThatsMrTalbot

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maelvls @ThatsMrTalbot @hawksight