Skip to content

Revise ACME Azure DNS-01 authentication docs for accuracy#1991

Merged
SgtCoDFish merged 1 commit intocert-manager:masterfrom
lunarwhite:az
Mar 3, 2026
Merged

Revise ACME Azure DNS-01 authentication docs for accuracy#1991
SgtCoDFish merged 1 commit intocert-manager:masterfrom
lunarwhite:az

Conversation

@lunarwhite
Copy link
Member

@lunarwhite lunarwhite commented Mar 3, 2026 •
edited
Loading

Changes

  • Remove outdated (and redundant) service account label azure.workload.identity/use (closes Azure DNS Documentation Update #1609)
  • Remove outdated comment about aks-preview extension requirement
  • Add missing --resource-group param to az identity commands
  • Add clarification about managedIdentity.clientID and managedIdentity.tenantID overriding
  • Fix doc contents formatting

Preview

@lunarwhite
Revise ACME Azure DNS-01 authentication docs
c68f211 
- Remove outdated service account labels
- Add missing --resource-group param to az identity commands
- Improve some more docs clarity and formatting

Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 3, 2026
@netlify
Copy link

netlify bot commented Mar 3, 2026

✅ Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c68f211
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/69a673daae90590008f1edbb
😎 Deploy Preview https://deploy-preview-1991--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hawksight
Copy link
Member

hawksight commented Mar 3, 2026

Hey thanks for taking the time to update this doc for us. I believe this looks more complete that #1259 which was opened a while ago. So my preference is to close that one and merge this instead.

I'm making the assumption it all works as I don't have an Azure tenant to test this on.

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@hawksight hawksight requested a review from wallrj March 3, 2026 09:26
@hawksight hawksight mentioned this pull request Mar 3, 2026
Closed
SgtCoDFish
SgtCoDFish approved these changes Mar 3, 2026
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Amazing, thank you so much!

I have ~0 Azure experience but @hawksight said this looks good and I can't see anything stylistically wrong so let's merge 🚀

@cert-manager-prow
Copy link
Contributor

cert-manager-prow bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@SgtCoDFish SgtCoDFish merged commit 0f85690 into cert-manager:master Mar 3, 2026
7 checks passed
@lunarwhite lunarwhite deleted the az branch March 3, 2026 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

@wallrj wallrj Awaiting requested review from wallrj

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Azure DNS Documentation Update

3 participants

@lunarwhite @hawksight @SgtCoDFish