-
Notifications
You must be signed in to change notification settings - Fork 392
[master] (release 1.20) Merge release-next into master #2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 23 commits
4fcfad1
d481d62
cc5edae
26521cb
c32f9cf
077192c
b14023f
cb65c79
b30933a
4f4027c
9731efa
2e29f61
315b301
8336efc
e4d264f
6a9fa66
b3f207c
3bf9e7c
4432928
ed5d6b9
6016ace
b100485
7d32c16
64342e0
90cb77c
1c95724
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -304,3 +304,45 @@ metadata: | |||||||||||||
| ] | ||||||||||||||
| ... | ||||||||||||||
| ``` | ||||||||||||||
|
|
||||||||||||||
| ### Issuer Custom Fields | ||||||||||||||
|
|
||||||||||||||
| Starting `v1.20`, you can use `venafi.cert-manager.io/custom-fields` annotation on an `Issuer` or `ClusterIssuer` resource. | ||||||||||||||
| This configuration would be applied to all Certificate requests created from `Issuer`. | ||||||||||||||
|
|
||||||||||||||
| It is possible to override or append custom configuration to `Certificate` resources via the `Issuer` assigned to it. | ||||||||||||||
| For example with an `Issuer` such as: | ||||||||||||||
|
|
||||||||||||||
| ```yaml | ||||||||||||||
| apiVersion: cert-manager.io/v1 | ||||||||||||||
| kind: Issuer | ||||||||||||||
| metadata: | ||||||||||||||
| name: corp-issuer | ||||||||||||||
| annotations: | ||||||||||||||
| venafi.cert-manager.io/custom-fields: |- | ||||||||||||||
| [ | ||||||||||||||
| {"name": "Environemnt", "value": "Dev"}, | ||||||||||||||
| ] | ||||||||||||||
| ``` | ||||||||||||||
|
Comment on lines
+322
to
+326
|
||||||||||||||
|
|
||||||||||||||
| and a `Certificate` resource: | ||||||||||||||
|
|
||||||||||||||
| ```yaml | ||||||||||||||
| apiVersion: cert-manager.io/v1 | ||||||||||||||
| kind: Certificate | ||||||||||||||
| metadata: | ||||||||||||||
| name: example-com-certificate | ||||||||||||||
| annotations: | ||||||||||||||
| venafi.cert-manager.io/custom-fields: |- | ||||||||||||||
| [ | ||||||||||||||
| {"name": "Team", "value": "amber"}, | ||||||||||||||
| ] | ||||||||||||||
|
Comment on lines
+336
to
+339
|
||||||||||||||
| ... | ||||||||||||||
| ``` | ||||||||||||||
|
|
||||||||||||||
| Final configuration will be: | ||||||||||||||
|
|
||||||||||||||
| ```json | ||||||||||||||
| {"name": "Environemnt", "value": "Dev"}, | ||||||||||||||
| {"name": "Team", "value": "amber"} | ||||||||||||||
|
Comment on lines
+346
to
+347
|
||||||||||||||
| {"name": "Environemnt", "value": "Dev"}, | |
| {"name": "Team", "value": "amber"} | |
| [ | |
| {"name": "Environemnt", "value": "Dev"}, | |
| {"name": "Team", "value": "amber"} | |
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,16 @@ | |
| "path": "/docs/releases/README.md" | ||
| }, | ||
| { | ||
| "title": "1.19", | ||
| "path": "/docs/releases/release-notes/release-notes-1.19.md" | ||
| "title": "1.20", | ||
| "path": "/docs/releases/release-notes/release-notes-1.20.md" | ||
| }, | ||
| { | ||
| "title": "Upgrade 1.19 to 1.20", | ||
| "path": "/docs/releases/upgrading/upgrading-1.19-1.20.md" | ||
| }, | ||
| { | ||
| "title": "1.19", | ||
| "path": "/docs/releases/release-notes/release-notes-1.19.md" | ||
| }, | ||
|
Comment on lines
+28
to
34
|
||
| { | ||
| "title": "Upgrade 1.18 to 1.19", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,12 +27,43 @@ This is useful for keeping compatibility with the `ingress-gce` component. | |
| ## acme.cert-manager.io/http01-ingress-class | ||
| - [Ingress](../usage/ingress.md) | ||
|
|
||
| this annotation allows you to configure the ingress class that will be used to | ||
| solve challenges for this ingress. Customizing this is useful when you are | ||
| trying to secure internal services, and need to solve challenges using a | ||
| different ingress class to that of the ingress. If not specified and the | ||
| `acme-http01-edit-in-place` annotation is not set, this defaults to the ingress | ||
| class defined in the Issuer resource. | ||
| Allows the `kubernetes.io/ingress.class` annotation to be configured. | ||
| Customizing this is useful when you are trying | ||
| to secure internal services, and need to solve challenges using a different ingress class | ||
| to that of the ingress. If not specified and the `acme-http01-edit-in-place` annotation is | ||
| not set, this defaults to the `http01.ingress.class` defined in the Issuer resource. | ||
|
Comment on lines
+30
to
+34
|
||
|
|
||
| ## acme.cert-manager.io/http01-ingress-ingressclassname | ||
|
|
||
| - [Ingress](../usage/ingress.md) | ||
|
|
||
| Allows the Ingress's `spec.ingressClassName` to be configured. | ||
| Customizing this is useful when you are trying | ||
| to secure internal services, and need to solve challenges using a different ingress class | ||
| to that of the ingress. If not specified and the `acme-http01-edit-in-place` annotation is | ||
| not set, this defaults to the `http01.ingress.ingressClassName` defined in the Issuer resource. | ||
|
Comment on lines
+40
to
+44
|
||
|
|
||
| ## acme.cert-manager.io/http01-parentrefkind | ||
|
|
||
| - [Certificate](../usage/certificate.md) | ||
|
|
||
| This annotation is automatically added by cert-manager to Certificate resources | ||
| when they are created from a [Gateway](../usage/gateway.md) or | ||
| [ListenerSet](../usage/gateway.md#listenerset) resource. It stores the kind of | ||
| the parent resource (either `Gateway` or `ListenerSet`) that triggered the | ||
| creation of the Certificate. This is used internally by the ACME HTTP-01 solver | ||
| to know where to attach the temporary HTTPRoute for the challenge. | ||
|
|
||
| ## acme.cert-manager.io/http01-parentrefname | ||
|
|
||
| - [Certificate](../usage/certificate.md) | ||
|
|
||
| This annotation is automatically added by cert-manager to Certificate resources | ||
| when they are created from a [Gateway](../usage/gateway.md) or | ||
| [ListenerSet](../usage/gateway.md#listenerset) resource. It stores the name of | ||
| the parent resource that triggered the creation of the Certificate. This is used | ||
| internally by the ACME HTTP-01 solver to know where to attach the temporary | ||
| HTTPRoute for the challenge. | ||
|
|
||
| ## cert-manager.io/allow-direct-injection | ||
| - `Secret` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field name "Environemnt" appears to be misspelled; if this is intended to be an environment field, it should be "Environment" to avoid propagating a typo into user configs.