Merged
Conversation
Contributor
|
Sorry, just noticed this PR! Not ignoring you, will review soon! |
ohemorange
requested changes
Jan 30, 2025
Contributor
ohemorange
left a comment
ohemorange
left a comment
There was a problem hiding this comment.
I'm so excited to see this!!! Just a few small changes, really.
Contributor
Author
|
Thank you! Now we're all one step closer to slimming down our memory footprints! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated PR as requested in #197.
As this is a breaking change, I bumped the release to 2.0.0, and I added docstrings with
versionchangedto the relevant functions, so anyone hit by this will better understand what happened.As this is a breaking change, there has been an exhaustive amount of discussion on best to handle this:
Cross References:
Deprecation of ComparableX509:
Explored Alternatives
ComparableX509in encoding and decoding functions #204pyOpenSSL& drop Python 3.7 support #182Solves:
OpenSSL.crypto.X509Reqis deprecated in PyOpenSSL 24.2+ #181