WIP Add support for Ed25519, Ed448, X25519 and X448. RFC 8037#98
WIP Add support for Ed25519, Ed448, X25519 and X448. RFC 8037#98atombrella wants to merge 37 commits intocertbot:mainfrom
Conversation
|
Please see issue #45 |
alexzorin
added
enhancement
priority: unplanned
atombrella
left a comment
atombrella
left a comment
There was a problem hiding this comment.
Just a few notes for myself.
| from cryptography.hazmat.primitives.asymmetric import ec | ||
| from cryptography.hazmat.primitives.asymmetric import rsa | ||
|
|
||
| from cryptography.hazmat.primitives.asymmetric import ( |
There was a problem hiding this comment.
I'm not sure if there are coding guidelines about grouping imports.
|
|
||
| # TODO: write the thumbprint | ||
| thumbprint = ( | ||
| b'kPrK_qmxVWaYVA9wwBF6Iuo3vVzz7TxHCTwXBygrS4k' |
There was a problem hiding this comment.
I'm not sure what the thumbprint should be here. Some guidance would be appreciated.
There was a problem hiding this comment.
Does this help? If not, can you tell me more about the type of guidance you're looking for here.
There was a problem hiding this comment.
I think this is fine. I'll try to push some more tests, and changes. I'm not really sure why the thumbprint of all of the tested keys is not tested, please see JWKECTest for an example. So I think just testing one key works?
There was a problem hiding this comment.
I think a gist to generate them would be helpful.
There was a problem hiding this comment.
Ah I see. Yes, I think testing all of them would be ideal.
I think there could be a clever design here either extending base class logic and giving each key its own test class or having a list of thumbprints and keys to test. If testing all of them proves difficult for some reason though, I wouldn't worry too much about it.
|
@JamesTheAwesomeDude You're welcome to assist a bit in getting this in a mergeable state. |
# Conflicts: # src/josepy/jwa.py # src/josepy/jwk.py # src/josepy/util.py
4 participants
This is still pretty much WIP!