Fix brace content and spike anchors to account for flip parameter #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When flip: true, the brace is drawn pointing in the opposite direction, but the spike and content anchors were always positioned using positive amplitude values. This caused labels to appear on the wrong side of flipped braces. This fix multiplies both amplitude and content-offset by -1 when flip is true, ensuring anchors are positioned correctly on both normal and flipped braces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
flip: trueis set on a brace, the brace is drawn pointing in the opposite direction, but thespikeandcontentanchors were always positioned using positive amplitude values. This caused labels to appear on the wrong side of flipped braces.Solution
This fix multiplies both
amplitudeandcontent-offsetby -1 whenflipis true, ensuring anchors are positioned correctly on both normal and flipped braces.Related Issues
This is similar to the fix for
flat-bracein PR #688, but applies to the regularbracefunction which was not included in that fix.Testing
Tested with both horizontal and diagonal braces, with and without flip. Labels now correctly position on the appropriate side of the brace in all cases.