mark: fix handling of stroke: none#1058
Closed
NicoWeio wants to merge 1 commit intocetz-package:masterfrom
Closed
Conversation
johannes-wolf
added a commit
that referenced
this pull request
Mar 19, 2026
When passing `none` to a `stroke:` style, cetz did create an invalid stroke object. ref #1058
johannes-wolf
added a commit
that referenced
this pull request
Mar 19, 2026
When passing `none` to a `stroke:` style, cetz did create an invalid stroke object. ref #1058
Member
|
Thank you for bringing this up. I've merged a different fix for this issue. |
johannes-wolf
added a commit
that referenced
this pull request
Mar 19, 2026
When passing `none` to a `stroke:` style, cetz did create an invalid stroke object. ref #1058
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following minimal example results in an error:
I found that this is because we do not actually pass
stroke: nonetostd.curveincanvas.typ. Instead,util.resolve-strokewill create a dict with invalid (in Typst) values:Within CeTZ,
resolve-strokeis only used in themark.typfile, so it should be safe to change its behavior.I can think of many ways to solve this, but since my testing environment is broken right now, I just wanted to put this out for discussion.