Skip to content

Suggesting more universal column spacing for song listings #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rkratky wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Suggesting more universal column spacing for song listings #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
126ddce
Edit song object to 'ui_weights = (2, 1, 1, 0.2, 0.2)'.
May 10, 2020
19a09ed
Add ui_weights to Albums.
May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tuijam/music_objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def header_ui(*txts, weights=()):


class Song(MusicObject):
ui_weights = (1, 2, 1, 0.2, 0.2)
ui_weights = (2, 1, 1, 0.2, 0.2)

def __init__(
self,
Expand Down Expand Up @@ -183,6 +183,8 @@ def from_dict(d):


class Album(MusicObject):
ui_weights = (1, 1, 0.1)

def __init__(self, title, artist, artistId, year, id_):

self.title = title
Expand All @@ -195,11 +197,11 @@ def __repr__(self):
return f"<Album title:{self.title}, artist:{self.artist}, year:{self.year}>"

def ui(self):
return self.to_ui(self.title, self.artist, self.year)
return self.to_ui(self.title, self.artist, self.year, weights=self.ui_weights)

@staticmethod
def header():
return MusicObject.header_ui(_("Album"), _("Artist"), _("Year"))
@classmethod
def header(cls):
return MusicObject.header_ui(_("Album"), _("Artist"), _("Year"), weights=cls.ui_weights)

@staticmethod
def from_dict(d):
Expand Down