Skip to content

Govet #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfergeau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Govet #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/make-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ jobs:
with:
go-version: ${{ matrix.go }}
- name: Build
run: make check
run: make vet
- if: runner.os == 'Linux'
name: Go version check
run: make goversioncheck
- if: runner.os == 'macOS'
name: pkg-config check
run: command -v pkg-config || echo "pkg-config is missing"
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,10 @@ e2e-story-microshift: install
fmt: $(TOOLS_BINDIR)/goimports
@$(TOOLS_BINDIR)/goimports -l -w $(SOURCE_DIRS)

.PHONY: vet
vet: gen_release_info
go vet -tags "containers_image_openpgp,build" ./...

# Run golangci-lint against code
.PHONY: lint cross-lint
lint: $(TOOLS_BINDIR)/golangci-lint gen_release_info
Expand Down