Add rate-explorer tests for some dynamic content #7633
+157
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
So turns out this is blocked by there not being example data for the rate checker API in our test data, which is what the Cypress tests run against in GitHub Actions. |
Member
Author
|
Use [ghe]/OAH/OAH-notes/wiki/Explore-Rates-high-balance-logic as a guide to building out test suite. |
Member
Author
|
Flagging @wpears and @mistergone if they get into adding additional test data to rate-explorer and need some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Touching rate-explorer scares me, let's have some tests for the dynamically displayed drop-downs and alerts.
Additions
How to test this PR
yarn cypress opento test manually.