Restore DEBUG=True by default #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially reverts PR 131. We want to keep DEBUG=True by default when running the webserver (for easy static files and nice debug errors), but we still want the ability to disable DEBUG mode when crawling. Add the ability to disable DEBUG via the DJANGO_DEBUG environment variable. Our nightly crawl is configured in an internal crawler-deploy repo that contains the helm chart, so a related change must be made there as well.
anselmbradford
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #131. We want to keep
DEBUG=Trueby default when running the webserver (for easy static files and nice debug errors), but we still want the ability to disableDEBUGmode when crawling.Add the ability to disable
DEBUGvia theDJANGO_DEBUGenvironment variable. Our nightly crawl is configured in an internal crawler-deploy repo that contains the helm chart, so a related change must be made there as well.