Conversation
Was actually pointing to POPCON hash
This was referenced Jun 17, 2025
Co-authored-by: Misha Veldhoen <misha.veldhoen@gmail.com>
Co-authored-by: Misha Veldhoen <misha.veldhoen@gmail.com>
MishaVeldhoen
approved these changes
Jun 17, 2025
Collaborator
MishaVeldhoen
left a comment
There was a problem hiding this comment.
Looks good! Left a couple of small comments, mostly nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates atomic data handling to work with https://github.com/cfs-energy/radas/tree/v2025.6.1.
Main fix
By default,
radas@v2025.6.1computes only a singlene_tauvalue. This breaks a line of logic in theAtomicDataclass. Although this can be fixed with a small patch, I decided it was worth refactoring some of the code to use a neaterCoeffInterpolatorextendingRectBivariateSplineto handle the log-space interpolation.Related fixes
radas_config.yamladded tocfspopconto make it clearer how radas is being configured.calc_impurity_charge_stateandcalc_impurity_radiated_power_radassimplified and made unit-aware, using the.groupby(dimension).map(function)xarray functionality.mypychanges.ne_taufor the SPARC PRD to 0.5 * ms * n20 from 1 * ms * n20, matching the value evaluated by radastest_atomic_datafor new implementationDrive-by fixes
poetrywas updated to version 2.1.3 (locally and in Github actions)get_itemandget_valueshelper methods used to replace common patternsevaluate_density_and_temperature_profile_fitssimplifiedwraps_ufuncerror handling would fail if function is unnamed.