Conversation
mdavids-cfs
left a comment
mdavids-cfs
left a comment
There was a problem hiding this comment.
I think it might be helpful to add a few sentences to grid.py to clarify the overwrites for rmin, zmin... at least I got a little lost there
| @@ -0,0 +1,13 @@ | |||
| """Grid input definitions""" | |||
|
|
|||
| GridSpec = tuple[float, int, float, int] | |||
There was a problem hiding this comment.
Not entirely sure what this means... intuitively I would guess that Grid spec is a full definition of a given regular grid; wouldn't that mean we also need the resolution info? Maybe just another sentence of what exactly is defined here might help
There was a problem hiding this comment.
The resolution is already a required input (dxgrid), so adding it again here would be redundant.
| rmesh, zmesh = np.meshgrid(rgrid, zgrid, indexing="ij") # [m] | ||
| if self.gridspec is not None: | ||
| # Make the grid | ||
| rmin, nr, zmin, nz = self.gridspec |
There was a problem hiding this comment.
Slightly confused about the redundant quantities for rmin and zmin here; extent is overwriting info in gridspec?
There was a problem hiding this comment.
When an exact gridspec is provided, min_extent is updated to match the spec. So, they're the same number here.
2 participants
3.1.0 - 2025-07-11
Added
gridmodule with types related to grid inputsChanged
typical()andtypical_outputsto use min_extent and gridspec inputs