Skip to content

fix: pkg_manifest_minimal example #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix: pkg_manifest_minimal example #1458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78824c1
fix: pkg_manifest_minimal example
cgrindel Jan 25, 2025
c530eb1
Merge branch 'main' into fix_pkg_manifest_example
mergify[bot] Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/pkg_manifest_minimal/do_test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ assert_match() {
# Run MyExecutable target
output="$("${bazel}" run //Sources/MyExecutable)"
assert_match "Good morning, World!" "${output}"
assert_match "Olivia .* 30 years old" "${output}"

# Run old-style executable in my_local_package
output="$("${bazel}" run @swiftpkg_my_local_package//:print-greeting)"
Expand Down
4 changes: 2 additions & 2 deletions .../third_party/NotThatAmazingModule/Sources/NotThatAmazingModule/NotThatAmazingModule.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ public class ComplexClass {
self.favoriteColors = favoriteColors
}

public func greet() {
print("Hello, my name is \(name) and I'm \(age) years old.")
public func greet() -> String {
return "Hello, my name is \(name) and I'm \(age) years old."
}

public func addFavoriteColor(color: String) {
Expand Down
Loading