feat: Support supplying .netrc file #1857
Open
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adincebic
requested review from
brentleyjones,
cgrindel,
jpsim and
luispadron
as code owners
adincebic
changed the title
cgrindel
requested changes
Oct 8, 2025
There was a problem hiding this comment.
It looks like you need to execute bazel run //:tidy and check in the updated files. I suspect that the test timeouts are not related to your changes.
Can you think of a way to test or exercise this netrc functionality? Could we create a noop .netrc file and then verify that certain behaviors occured?
|
I forgot to mention. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very useful for the packages that require form of authentication to clone or download binary artifacts.
It is true that SPM and rules_swift_package_manager work without this if the
.netrcfile is in$HOMEbut there are use cases where it is desirable to have.netrcrelative to the bazel workspace.