Trying to revive the USBD example #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver works for the most part, except you must for some reason use the arch-spin executor to make it work. Perhaps something is wrong in the interrupts? Do not merge in the current form!
Origin/usbd example
| let regs = T::regs(); | ||
| let x = regs.istr().read().0; | ||
| crate::println!("USB IRQ: {:08x}", x); | ||
| // let x = regs.istr().read().0; |
Member
There was a problem hiding this comment.
Ideally we don't leave code just "commented out"
Member
There was a problem hiding this comment.
I think we can just remove them.
Codetector1374
requested changes
Dec 2, 2025
Member
Codetector1374
left a comment
Codetector1374
left a comment
There was a problem hiding this comment.
LGTM overall, given it only touches example and remove prints from usbd driver. Once we cleanup the commented out prints in the driver I think this is good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch https://github.com/ch32-rs/ch32-hal/tree/usbd-example seems to be abandoned, this attempts to incorporate the comments on the branch and update to main.