Skip to content

fix: In memory implementation remove() did not propagate default value #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kalinjul wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: In memory implementation remove() did not propagate default value #99

kalinjul wants to merge 2 commits into from

Conversation

@kalinjul
Copy link
Collaborator

@kalinjul kalinjul commented Dec 12, 2023

While collecting a settings value flow, calling remove() did not propagate to the collector when using the in memory implementation

ch4rl3x
ch4rl3x previously approved these changes Dec 12, 2023
View reviewed changes
@ch4rl3x
Copy link
Owner

ch4rl3x commented Dec 12, 2023

Please fix spotless with gradle task spotlessApply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ch4rl3x ch4rl3x ch4rl3x left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalinjul @ch4rl3x