Skip to content

Update to rollup 3 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francois2metz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to rollup 3 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e36ec
Update to rollup 3
francois2metz May 20, 2023
4f95a5d
Run tests against node 14, 16 and 18
francois2metz May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
# Test against these versions of Node.js.
environment:
matrix:
- nodejs_version: '12'
- nodejs_version: '14'
- nodejs_version: '16'
- nodejs_version: '18'
cache:
- "%LOCALAPPDATA%\\Yarn"
# Install scripts. (runs after repo cloning)
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
"fs-tree-diff": "^2.0.1",
"heimdalljs": "^0.2.6",
"node-modules-path": "^1.0.1",
"rollup": "^2.50.0",
"rollup": "^3.0.0",
"rollup-pluginutils": "^2.8.1",
"symlink-or-copy": "^1.2.0",
"walk-sync": "^2.2.0"
"walk-sync": "^3.0.0"
},
"devDependencies": {
"@types/node": "^15.6.1",
Expand Down
70 changes: 35 additions & 35 deletions tests/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe('Staging files smoke tests', () => {

assert.deepEqual(output.read(), {
'out.js':
'const minus = num => num--;\n\nconst two = minus(3);\n\nconst add = num => num++;\n\nconst result = add(two);\n\nexport default result;\n',
'const minus = num => num--;\n\nconst two = minus(3);\n\nconst add = num => num++;\n\nconst result = add(two);\n\nexport { result as default };\n',
});
});
});
Expand Down Expand Up @@ -82,7 +82,7 @@ describe('BroccoliRollup', hooks => {

const two = add(1);

export default two;
export { two as default };
`,
});
assert.deepEqual(output.changes(), {
Expand All @@ -101,7 +101,7 @@ export default two;

const two = add(1);

export default two;
export { two as default };
`,
});
assert.deepEqual(output.changes(), {});
Expand All @@ -121,7 +121,7 @@ var minus = x => x - x;

var index = { a: add(1), b: minus(1) };

export default index;
export { index as default };
`,
});
assert.deepEqual(output.changes(), {
Expand Down Expand Up @@ -155,7 +155,7 @@ export default index;

var index = add(1);

export default index;
export { index as default };
`,
});
assert.deepEqual(output.changes(), {
Expand Down Expand Up @@ -205,7 +205,7 @@ export default index;

const two = add(1);

export default two;
export { two as default };
`,
});
assert.deepEqual(output.changes(), {
Expand All @@ -226,7 +226,7 @@ export default two;

const two = add(1);

export default two;
export { two as default };
`,
});
assert.deepEqual(output.changes(), {});
Expand All @@ -248,7 +248,7 @@ var minus = x => x - x;

var index = { a: add(1), b: minus(1) };

export default index;
export { index as default };
`,
});
assert.deepEqual(output.changes(), {
Expand Down Expand Up @@ -284,7 +284,7 @@ export default index;

var index = add(1);

export default index;
export { index as default };
`,
});
assert.deepEqual(output.changes(), {
Expand Down Expand Up @@ -344,7 +344,7 @@ export default index;

const two = add(1);

export default two;
export { two as default };
`,
});
assert.deepEqual(output.changes(), {
Expand All @@ -361,7 +361,7 @@ export default two;

const two = add(1);

export default two;
export { two as default };
`,
});
assert.deepEqual(output.changes(), {});
Expand All @@ -381,7 +381,7 @@ var minus = x => x - x;

var index = { a: add(1), b: minus(1) };

export default index;
export { index as default };
`,
});
assert.deepEqual(output.changes(), {
Expand Down Expand Up @@ -428,7 +428,7 @@ export default index;
assert.deepEqual(output.read(), {
dist: {
'out.umd.js':
"(function (global, factory) {\n\ttypeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :\n\ttypeof define === 'function' && define.amd ? define(factory) :\n\t(global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.thing = factory());\n}(this, (function () { 'use strict';\n\n\tvar add = x => x + x;\n\n\tconst two = add(1);\n\n\treturn two;\n\n})));\n",
"(function (global, factory) {\n\ttypeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :\n\ttypeof define === 'function' && define.amd ? define(factory) :\n\t(global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.thing = factory());\n})(this, (function () { 'use strict';\n\n\tvar add = x => x + x;\n\n\tconst two = add(1);\n\n\treturn two;\n\n}));\n",
},
});
} finally {
Expand Down Expand Up @@ -461,9 +461,9 @@ export default index;

assert.deepEqual(output.read(), {
dist: {
'out.js': "var add = x => x + x;\n\nconst two = add(1);\n\nexport default two;\n//# sourceMappingURL=out.js.map\n",
'out.js': "var add = x => x + x;\n\nconst two = add(1);\n\nexport { two as default };\n//# sourceMappingURL=out.js.map\n",
'out.js.map': "{\"version\":3,\"file\":\"out.js\",\"sources\":[\"../add.js\",\"../index.js\"],\"sourcesContent\":[\"export default x => x + x;\",\"import add from \\\"./add\\\"; const two = add(1); export default two;\"],\"names\":[],\"mappings\":\"AAAA,UAAe,CAAC,IAAI,CAAC,GAAG,CAAC;;ACAK,MAAC,GAAG,GAAG,GAAG,CAAC,CAAC;;;;\"}",
'out.umd.js': "(function (global, factory) {\n\ttypeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :\n\ttypeof define === 'function' && define.amd ? define(factory) :\n\t(global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.thing = factory());\n}(this, (function () { 'use strict';\n\n\tvar add = x => x + x;\n\n\tconst two = add(1);\n\n\treturn two;\n\n})));\n"
'out.umd.js': "(function (global, factory) {\n\ttypeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :\n\ttypeof define === 'function' && define.amd ? define(factory) :\n\t(global = typeof globalThis !== 'undefined' ? globalThis : global || self, global.thing = factory());\n})(this, (function () { 'use strict';\n\n\tvar add = x => x + x;\n\n\tconst two = add(1);\n\n\treturn two;\n\n}));\n"
},
});
} finally {
Expand Down Expand Up @@ -524,9 +524,9 @@ export default index;

assert.deepEqual(output.read(), {
chunks: {
'a.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-0f663cdb.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'a.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-3d3abf85.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'f.js': "const num4 = 4;\n\nexport { num4 };\n"
},
});
Expand Down Expand Up @@ -587,9 +587,9 @@ export default index;
// our output should still be the same as before noops and errors
assert.deepEqual(output.read(), {
chunks: {
'a.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-0f663cdb.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'a.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-3d3abf85.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'f.js': "const num4 = 4;\n\nexport { num4 };\n"
},
});
Expand All @@ -610,9 +610,9 @@ export default index;

assert.deepEqual(output.read(), {
chunks: {
'a.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-0f663cdb.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'a.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-3d3abf85.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'f.js': "function foo() {}\n\nexport { foo };\n"
},
});
Expand All @@ -627,19 +627,19 @@ export default index;
output.changes(),
{
'chunks/b.js': 'change',
'chunks/d-ebe94d27.js': 'create',
'chunks/f.js': 'change'
'chunks/f-371d3ac9.js': 'create',
'chunks/f.js': 'change'
},
'only the entry point affected by the change should change',
);

assert.deepEqual(output.read(), {
chunks: {
'a.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num2 } from './d-ebe94d27.js';\nimport { n as num3 } from './e-0f663cdb.js';\n\nconst out = num2 + num3;\n\nexport { out };\n",
"d-ebe94d27.js": "const num2 = 2; const foo = \"bar\";\n\nexport { foo as f, num2 as n };\n",
'e-0f663cdb.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'f.js': "export { f as foo } from './d-ebe94d27.js';\n"
'a.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num2 } from './f-371d3ac9.js';\nimport { n as num3 } from './e-3d3abf85.js';\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-3d3abf85.js': "const num3 = 3;\n\nexport { num3 as n };\n",
"f-371d3ac9.js": "const num2 = 2; const foo = \"bar\";\n\nexport { foo as f, num2 as n };\n",
'f.js': "export { f as foo } from './f-371d3ac9.js';\n"
},
});

Expand All @@ -653,7 +653,7 @@ export default index;
assert.deepEqual(
output.changes(),
{
'chunks/d-ebe94d27.js': 'unlink',
'chunks/f-371d3ac9.js': 'unlink',
'chunks/b.js': 'change',
'chunks/f.js': 'change'
},
Expand All @@ -662,9 +662,9 @@ export default index;

assert.deepEqual(output.read(), {
chunks: {
'a.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-0f663cdb.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-0f663cdb.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'a.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num1 = 1;\n\nconst out = num1 + num3;\n\nexport { out };\n",
'b.js': "import { n as num3 } from './e-3d3abf85.js';\n\nconst num2 = 2;\n\nconst out = num2 + num3;\n\nexport { out };\n",
'e-3d3abf85.js': "const num3 = 3;\n\nexport { num3 as n };\n",
'f.js': "function foo() {}\n\nexport { foo };\n"
},
});
Expand Down
Loading