handle case with all coins being in tooltip#115
Open
rehandaphedar wants to merge 1 commit intochadsr:masterfrom
Open
handle case with all coins being in tooltip#115rehandaphedar wants to merge 1 commit intochadsr:masterfrom
rehandaphedar wants to merge 1 commit intochadsr:masterfrom
Conversation
Owner
|
Hmm yes, I had not thought of this use-case, good catch and thanks for the PR! Splitting the output across the bar and tool-tip would require quite some refactoring I think. FYI there seems to be a typo caught by the linter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually I'm not sure as to if there could be a better implementation than this.
Maybe an option to just show the price in the bar and rest of the data in the tooltip?