-
-
Notifications
You must be signed in to change notification settings - Fork 54
fix: prevent eager evaluation of components with external dependencies #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: surajair <[email protected]>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
sdk | 2390a38 | Jan 07 2026, 04:29 AM |
…r evaluation Co-authored-by: surajair <[email protected]>
Co-authored-by: surajair <[email protected]>
Co-authored-by: surajair <[email protected]>
|
@copilot you used main branch. use the |
Done! I've rebased the changes to use the The key changes remain the same:
All 374 tests pass and the build completes successfully on the Commits: 88f8bee, 6ab52ab |
Fix for Default Builder Not Loading on / Route
Note: This PR has been rebased to use the
nextbranch as requested.Changes Made
maintonextbranch@/routes/demo/panels/panelimport insideextendChaiBuilder()functionuse-current-page.tsabout QueryClient requirementsSummary
Prevented eager evaluation of demo panels by moving the side-effect import from module-level to inside the
extendChaiBuilder()function insrc/routes/extentions.tsx(note: path changed fromsrc/extentions.tsxin main tosrc/routes/extentions.tsxin next). This ensures panel registrations with potential external dependencies (like QueryClient) don't execute until explicitly called.Files Changed
src/routes/extentions.tsx- Deferred panel import execution with error handlingsrc/core/hooks/use-current-page.ts- Added JSDoc documentation about QueryClientCONTRIBUTING_HOOKS.md- New developer guidelines documentPattern Applied
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.