Skip to content

Make jQuery a peer dependency and require it. #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make jQuery a peer dependency and require it. #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7471e1
Require jQuery using CommonJS (rather than using a global variable).
jacksonrayhamilton Nov 12, 2017
1ef6d0c
Add jQuery as a peer dependency.
jacksonrayhamilton Nov 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions chai-jquery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
// Module systems magic dance.
if (typeof require === "function" && typeof exports === "object" && typeof module === "object") {
// NodeJS
module.exports = chaiJquery;
module.exports = function (chai, utils) {
return chaiJquery(chai, utils, require('jquery'));
};
} else if (typeof define === "function" && define.amd) {
// AMD
define(['jquery'], function ($) {
Expand All @@ -19,7 +21,6 @@
}(function (chai, utils, $) {
var inspect = utils.inspect,
flag = utils.flag;
$ = $ || jQuery;

var setPrototypeOf = '__proto__' in Object ?
function (object, prototype) {
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,8 @@
"mocha": "1",
"mocha-phantomjs": "3",
"jquery": "2.1.0"
},
"peerDependencies": {
"jquery": "*"
}
}