Merged
Conversation
thedevbirb
force-pushed
the
lore/chore/msg-sim-config
branch
from
36e3ff5 to
37e8449
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
thedevbirb
force-pushed
the
lore/chore/msg-sim-config
branch
2 times, most recently
from
cf72175 to
90e71d9
Compare
merklefruit
reviewed
Jan 29, 2026
thedevbirb
force-pushed
the
lore/chore/msg-sim-config
branch
from
90e71d9 to
1d1185a
Compare
Karrq
approved these changes
Jan 30, 2026
thedevbirb
force-pushed
the
lore/chore/msg-sim-config
branch
from
c01815a to
012bd3c
Compare
thedevbirb
force-pushed
the
lore/chore/msg-sim-config
branch
from
012bd3c to
f60efc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to specify a runtime builder function when adding a new namespace (whether hub or peer) into the network.
Moreover, it separates between
PeerContextandCommonContext, while before there was no distinction and the hub had assigned apeer_idof zero due to shared interface.