-
Notifications
You must be signed in to change notification settings - Fork 14
feat(transport): TCP-TLS #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0e2ed03
3d04d6e
900e075
6f7aedc
e25b901
97935bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,64 @@ | ||
| use bytes::Bytes; | ||
| use msg_socket::{RepSocket, ReqSocket}; | ||
| use msg_transport::tcp::Tcp; | ||
| use msg_transport::{ | ||
| tcp::Tcp, | ||
| tcp_tls::{self, TcpTls}, | ||
| }; | ||
| use tokio_stream::StreamExt; | ||
|
|
||
| #[tokio::test(flavor = "multi_thread", worker_threads = 4)] | ||
| async fn test_reqrep() { | ||
| /// Helper functions. | ||
| mod helpers { | ||
| use std::{path::PathBuf, str::FromStr as _}; | ||
|
|
||
| use openssl::ssl::{ | ||
| SslAcceptor, SslAcceptorBuilder, SslConnector, SslConnectorBuilder, SslFiletype, SslMethod, | ||
| }; | ||
|
|
||
| /// Creates a default SSL acceptor builder for testing, with a trusted CA. | ||
| pub fn default_acceptor_builder() -> SslAcceptorBuilder { | ||
| let certificate_path = | ||
| PathBuf::from_str("../testdata/certificates/server-cert.pem").unwrap(); | ||
| let private_key_path = | ||
| PathBuf::from_str("../testdata/certificates/server-key.pem").unwrap(); | ||
| let ca_certificate_path = | ||
| PathBuf::from_str("../testdata/certificates/ca-cert.pem").unwrap(); | ||
|
|
||
| assert!(certificate_path.exists(), "Certificate file does not exist"); | ||
| assert!(private_key_path.exists(), "Private key file does not exist"); | ||
| assert!(ca_certificate_path.exists(), "CA Certificate file does not exist"); | ||
|
|
||
| let mut acceptor_builder = SslAcceptor::mozilla_intermediate(SslMethod::tls()).unwrap(); | ||
| acceptor_builder.set_certificate_file(certificate_path, SslFiletype::PEM).unwrap(); | ||
| acceptor_builder.set_private_key_file(private_key_path, SslFiletype::PEM).unwrap(); | ||
| acceptor_builder.set_ca_file(ca_certificate_path).unwrap(); | ||
| acceptor_builder | ||
| } | ||
|
|
||
| /// Creates a default SSL connector builder for testing, with a trusted CA. | ||
| /// It also has client certificate and private key set for mTLS testing. | ||
| pub fn default_connector_builder() -> SslConnectorBuilder { | ||
| let certificate_path = | ||
| PathBuf::from_str("../testdata/certificates/client-cert.pem").unwrap(); | ||
| let private_key_path = | ||
| PathBuf::from_str("../testdata/certificates/client-key.pem").unwrap(); | ||
| let ca_certificate_path = | ||
| PathBuf::from_str("../testdata/certificates/ca-cert.pem").unwrap(); | ||
|
|
||
| assert!(certificate_path.exists(), "Certificate file does not exist"); | ||
| assert!(private_key_path.exists(), "Private key file does not exist"); | ||
| assert!(ca_certificate_path.exists(), "CA Certificate file does not exist"); | ||
|
|
||
| let mut connector_builder = SslConnector::builder(SslMethod::tls()).unwrap(); | ||
| connector_builder.set_certificate_file(certificate_path, SslFiletype::PEM).unwrap(); | ||
| connector_builder.set_private_key_file(private_key_path, SslFiletype::PEM).unwrap(); | ||
| connector_builder.set_ca_file(ca_certificate_path).unwrap(); | ||
|
|
||
| connector_builder | ||
| } | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn reqrep_works() { | ||
| let _ = tracing_subscriber::fmt::try_init(); | ||
|
|
||
| let mut rep = RepSocket::new(Tcp::default()); | ||
|
|
@@ -21,6 +75,72 @@ async fn test_reqrep() { | |
| } | ||
| }); | ||
|
|
||
| let response = req.request(Bytes::from_static(b"hello")).await.unwrap(); | ||
| tracing::info!("Response: {:?}", response); | ||
| let hello = Bytes::from_static(b"hello"); | ||
| let response = req.request(hello.clone()).await.unwrap(); | ||
| assert_eq!(hello, response, "expected {:?}, got {:?}", hello, response); | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn reqrep_tls_works() { | ||
| let _ = tracing_subscriber::fmt::try_init(); | ||
|
|
||
| let server_config = tcp_tls::config::Server::new(helpers::default_acceptor_builder().build()); | ||
| let tcp_tls_server = TcpTls::new_server(server_config); | ||
| let mut rep = RepSocket::new(tcp_tls_server); | ||
|
|
||
| rep.bind("0.0.0.0:0").await.unwrap(); | ||
|
|
||
| let domain = "localhost".to_string(); | ||
| let ssl_connector = helpers::default_connector_builder().build(); | ||
| let tcp_tls_client = | ||
| TcpTls::new_client(tcp_tls::config::Client::new(domain).with_ssl_connector(ssl_connector)); | ||
| let mut req = ReqSocket::new(tcp_tls_client); | ||
|
|
||
| req.connect(rep.local_addr().unwrap()).await.unwrap(); | ||
|
|
||
| tokio::spawn(async move { | ||
| while let Some(request) = rep.next().await { | ||
| let msg = request.msg().clone(); | ||
| request.respond(msg).unwrap(); | ||
| } | ||
| }); | ||
|
|
||
| let hello = Bytes::from_static(b"hello"); | ||
| let response = req.request(hello.clone()).await.unwrap(); | ||
| assert_eq!(hello, response, "expected {:?}, got {:?}", hello, response); | ||
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn reqrep_mutual_tls_works() { | ||
| let _ = tracing_subscriber::fmt::try_init(); | ||
|
|
||
| let mut acceptor_builder = helpers::default_acceptor_builder(); | ||
| // By specifying peer verification mode, we essentially toggle mTLS. | ||
| acceptor_builder.set_verify( | ||
| openssl::ssl::SslVerifyMode::PEER | openssl::ssl::SslVerifyMode::FAIL_IF_NO_PEER_CERT, | ||
| ); | ||
|
Comment on lines
+119
to
+121
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be nice to offer this stuff as some easy to set up options on the server and the client in a follow-up, like |
||
| let server_config = tcp_tls::config::Server::new(acceptor_builder.build()); | ||
| let tcp_tls_server = TcpTls::new_server(server_config); | ||
| let mut rep = RepSocket::new(tcp_tls_server); | ||
|
|
||
| rep.bind("0.0.0.0:0").await.unwrap(); | ||
|
|
||
| let domain = "localhost".to_string(); | ||
| let ssl_connector = helpers::default_connector_builder().build(); | ||
| let tcp_tls_client = | ||
| TcpTls::new_client(tcp_tls::config::Client::new(domain).with_ssl_connector(ssl_connector)); | ||
| let mut req = ReqSocket::new(tcp_tls_client); | ||
|
|
||
| req.connect(rep.local_addr().unwrap()).await.unwrap(); | ||
|
|
||
| tokio::spawn(async move { | ||
| while let Some(request) = rep.next().await { | ||
| let msg = request.msg().clone(); | ||
| request.respond(msg).unwrap(); | ||
| } | ||
| }); | ||
|
|
||
| let hello = Bytes::from_static(b"hello"); | ||
| let response = req.request(hello.clone()).await.unwrap(); | ||
| assert_eq!(hello, response, "expected {:?}, got {:?}", hello, response); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For abstracting between tls backends we might want to expose a method to enable mtls, and have it manage how that’s done in openssl and rustls