Merged
Conversation
Closed
mempirate
approved these changes
Nov 17, 2025
Contributor
mempirate
left a comment
mempirate
left a comment
There was a problem hiding this comment.
Lgtm. Added a nit but up to you
thedevbirb
force-pushed
the
lore/feat/ipv6
branch
from
2c8e56f to
b6233ed
Compare
mempirate
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to give a stab at #63.
To me it seemed that there wasn't much to change, except a couple of tweaks to be aware of whether we're using IPv6 or not. To test it, I've added a commit (to be dropped after approval of the changes) where I replace all
127.0.0.1and0.0.0.0occurrences in both tests and benches, and they run fine.To avoid clutter in reading the PR, it can be read commit by commit.