[Tokei] Add more specification about typescript shown by Tokei#95
Open
heyolaniran wants to merge 1 commit intochaincodelabs:masterfrom
Open
[Tokei] Add more specification about typescript shown by Tokei#95heyolaniran wants to merge 1 commit intochaincodelabs:masterfrom
heyolaniran wants to merge 1 commit intochaincodelabs:masterfrom
Conversation
In the Project stats, Tokei considers all .ts files as typescript files. In the case of Bitcoin Core, .ts are related to translation files.
Collaborator
Hey @heyolaniran, thanskf for the PR. I think perhaps the clearer approach here would be to manually remove the Typescript line altogether (rather than add a note), and next time it's re-calculated on a version bump we can use I don't think highlighting translation chars is particularly useful in any way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @willcl-ark , in this PR i made some addition to the presence of typescript in the list of languages used in Bitcoin Core Repository.
In the Project stats, Tokei considers all .ts files as typescript files. In the case of Bitcoin Core, .ts are related to translation files.
Thank you for having time to review my suggestion and feel free to leave me any insights for improvements.