Ignore scripts that aren't executable #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should probably be an allowlist like apk does, but this is a smaller diff and I'm worried about breaking more things. Signed-off-by: Jon Johnson <jon.johnson@chainguard.dev>
luhring
reviewed
Dec 11, 2024
Comment on lines
+157
to
+160
| // Ignore files that aren't executable. | ||
| // This is mostly to ignore .melange.yaml files in the control section, | ||
| // but apk itself has hardcoded list of scripts that we might want to do too. | ||
| if header.FileInfo().Mode().Perm()&0555 != 0555 { |
Member
There was a problem hiding this comment.
It's not immediately obvious to me from this why we're checking for these exact perm bits (r+x for all 3) but maybe that's just because I don't know this part of the domain
Contributor
Author
There was a problem hiding this comment.
FWIW I copied this from melange SCA that does similar checks for entirely different reasons, and it matched what I saw from sampling real-world scripts in alpine. If this ends up being brittle I'll come back and figure out exactly what apk does here and replicate it.
luhring
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be an allowlist like apk does, but this is a smaller diff and I'm worried about breaking more things.