fix multi key support in APKINDEX verification #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnghia
force-pushed
the
fix-multi-key-support
branch
4 times, most recently
from
082a65e to
ca49d1e
Compare
Signed-off-by: Nghia Tran <tcnghia@gmail.com>
tcnghia
force-pushed
the
fix-multi-key-support
branch
from
ca49d1e to
d39d748
Compare
Signed-off-by: Nghia Tran <nghia@chainguard.dev>
tcnghia
force-pushed
the
fix-multi-key-support
branch
from
0edcb42 to
b8120a8
Compare
Signed-off-by: Nghia Tran <nghia@chainguard.dev>
tcnghia
force-pushed
the
fix-multi-key-support
branch
from
b8120a8 to
10822ff
Compare
Signed-off-by: Nghia Tran <nghia@chainguard.dev>
Signed-off-by: Nghia Tran <nghia@chainguard.dev>
jonjohnsonjr
approved these changes
Jan 22, 2025
tcnghia
changed the title
Member
|
@tcnghia thank you!!!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic uses the last .SIGN. file content as signature and verify that against all known keys. This PR fixes the logic to use matching signature to the right verification key.