MergeInto should favor the receiver value for run-as
#1967
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now this is backwards, so custom assembly overlays wouldn't appropriately override the base configuration's setting. Signed-off-by: Matt Moore <[email protected]>
imjasonh
reviewed
Dec 5, 2025
Comment on lines
160
to
162
| target.Users = slices.Concat(a.Users, target.Users) | ||
| target.Groups = slices.Concat(a.Groups, target.Groups) | ||
| return nil |
Member
There was a problem hiding this comment.
Are these wrong too? Do we need to dedupe (with preference for a) if a user or group is defined in both?
Member
Author
There was a problem hiding this comment.
You are right, we use this backwards from what I expected downstream, so I believe this is already doing what we want, and I just wrote the (downstream) test backwards.
imjasonh
reviewed
Dec 5, 2025
| StopSignal: "bar", | ||
| WorkDir: "bar", | ||
| Accounts: types.ImageAccounts{ | ||
| RunAs: "bar", |
Member
There was a problem hiding this comment.
Why do WorkDir, Cmd, etc., all get "bar" when this should get "foo"?
This code is weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this is backwards, so custom assembly overlays wouldn't appropriately override the base configuration's setting.