cache keys by name #1968
Merged
cache keys by name #1968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will test key discovery with matching ETags.
Cache keyrings by full name, as keys that are in the same location may have the same ETag.
Member
Author
|
@javacruft this is smaller in size change than #1949 yet critically addresses the current bad etag based caching of alpine keys. |
Member
Author
|
Also this new cache structure for keys makes them look more similar to our existing apk caches. |
javacruft
approved these changes
Dec 12, 2025
xnox
added a commit
to chainguard-dev/rules_apko
that referenced
this pull request
Dec 17, 2025
- **automated: Update to new apko release** - **Update for new key cashing structure** See: - chainguard-dev/apko#1968 - chainguard-dev/apko#1985 --------- Signed-off-by: octo-sts[bot] <157150467+octo-sts[bot]@users.noreply.github.com> Co-authored-by: octo-sts[bot] <157150467+octo-sts[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples: build multi-arch alpine-base
This will test key discovery with matching ETags.
Cache keyrings by full name
Cache keyrings by full name, as keys that are in the same location may
have the same ETag.
Build samples for all the declared architectures