sbom: Deduplicate filesystem arguments. #2003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBOM generators took in an SBOM at initialization, but also at Generate time. This meant there could be 2 different filesystems, but it was also unclear why we needed to have the filesystem at init time anyway, since it means that generators had to be tied 1:1 to their filesystems instead of reused for multiple files systems. In practice, these were the same filesystem being plumbed at 2 different places. This simplifies this so that we only use the Generate-time FS which makes the most sense. BREAKING CHANGE: - SBOM Generators no longer take a filesystem at init time. The filesystem passed in through the SBOM options at generation time is used.
markusthoemmes
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBOM generators took in an SBOM at initialization, but also at Generate time. This meant there could be 2 different filesystems, but it was also unclear why we needed to have the filesystem at init time anyway, since it means that generators had to be tied 1:1 to their filesystems instead of reused for multiple files systems.
In practice, these were the same filesystem being plumbed at 2 different places. This simplifies this so that we only use the Generate-time FS which makes the most sense.
BREAKING CHANGE: