Add lockfile support to build-minirootfs and build-cpio#2101
Open
alexhaydock wants to merge 2 commits intochainguard-dev:mainfrom
Open
Add lockfile support to build-minirootfs and build-cpio#2101alexhaydock wants to merge 2 commits intochainguard-dev:mainfrom
alexhaydock wants to merge 2 commits intochainguard-dev:mainfrom
Conversation
alexhaydock
force-pushed
the
expanded-lockfile-support
branch
from
462751d to
d961029
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to satisfy my own feature request (#2085) by wiring up the pre-existing lockfile support used by
apko buildso that it also works forapko build-minirootfsandapko build-cpio.I'm not the most familiar with the apko codebase and this deceptively simple but based on my testing, this does seem to be all that's required to get lockfile support functioning properly for both of these build modes.
This would be a really useful featureset as I've been using
apko build-cpioto build reproducible Alpine initramfs images and having locking support would make this build pipeline incredibly powerful by giving it long-term reproducibility.