add client id to grpc calls via interceptors and surface in grpc metrics#436
Merged
k4leung4 merged 6 commits intochainguard-dev:mainfrom Aug 12, 2025
Merged
add client id to grpc calls via interceptors and surface in grpc metrics#436k4leung4 merged 6 commits intochainguard-dev:mainfrom
k4leung4 merged 6 commits intochainguard-dev:mainfrom
Conversation
Contributor
|
Could we split this into 2 PRs please? It seems like the prometheus change has nothing to do with the clientID/requestID change. |
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Contributor
Author
done, ptal |
Contributor
Author
|
done, ptal |
markusthoemmes
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this updates the framework to stop using
github.com/grpc-ecosystem/go-grpc-prometheuswhich has been archived since apr 18, 2023two parts to the clientid
for clients, append a client id and request id to outgoing context for grpc
client id is the name of the executable
and request id is a generated uuid
for servers,
servers will need to include the new server interceptor to extract the clientid from context and attach it to the grpc metric
the requestid is not used at the moment for fear of metric cardinality concerns
for https://github.com/chainguard-dev/mono/issues/17367