add test for serving metrics for grpc#442
Merged
k4leung4 merged 2 commits intochainguard-dev:mainfrom Aug 11, 2025
Merged
Conversation
wlynch
reviewed
Aug 11, 2025
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| defer listener.Close() |
Member
There was a problem hiding this comment.
This potentially could race because you're grabbing a port, to then defer the close in the scope of this func which then frees the port, to then try to re-listen on the port later.
Ideally we'd pass the listener through, but idk how much refactoring you want to do in this PR. 🤷
Contributor
Author
There was a problem hiding this comment.
ack'ed
added a comment, i would like to get this in as is, and if it becomes flaky, happy to refactor
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
wlynch
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.