Bug: vermatch order make >= unmatchable#16
Open
jessequinn wants to merge 1 commit intochainguard-dev:mainfrom
Open
Bug: vermatch order make >= unmatchable#16jessequinn wants to merge 1 commit intochainguard-dev:mainfrom
jessequinn wants to merge 1 commit intochainguard-dev:mainfrom
Conversation
stevebeattie
reviewed
Apr 8, 2026
Member
stevebeattie
left a comment
stevebeattie
left a comment
There was a problem hiding this comment.
Similarly to #15, is there a chance you could add testcases around this? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order in verMatch makes >= unmatchable. goparsify.Any tries alternatives in order and returns the first match. The order is:
When the input is >=, the parser tries verGreaterThan first (which matches >) and returns immediately consuming only the > and leaving = unmatched. verGreaterThanEqual (>=) never gets tried.
I hit an issue with Melange chainguard-dev/melange#2137 due to this.
So freetype2 >= 9.8.3 in gd-dev's .pc file gets parsed as freetype2 > 9.8.3 with a leftover = causing a parse error or wrong comparison, which then makes the solver reject freetype2 at version 26.2.20 even though it clearly satisfies the constraint.