Update yara-x to 1.9.0; use new ScanFile functionality #1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates yara-x to
1.9.0and uses the newly-addedScanFilemethod as opposed to the originalScanmethod which only supported a byte slice.This allows yara-x to handle all of the memory mapping/file reading and cleans up a decent bit of code.
We still need the file contents for checksum calculations and report generation, so I updated the original
syscall.Mmap+bytes.Clonefunctionality withbytes.Buffer+io.CopyBufferinstead.