Avoid extracting joblib archives#729
Closed
egibs wants to merge 2 commits intochainguard-dev:mainfrom
Closed
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
d3c9c8c to
7dc9d41
Compare
|
I can't help but feel like hardcoding this exception introduces unnecessary complexity without a tangible benefit. Is this just to suppress output errors? |
Member
Author
Pretty much. Mainly since the files look like valid archives that should be extracting correctly. |
Signed-off-by: Evan Gibler <20933572+egibs@users.noreply.github.com>
Member
Author
|
Closing this out for now since it's just to quiet down errors for unsupported archive types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're encountering failures when trying to extract files such as:
While these appear to be valid gzip archives, they are actually just
application/octet-stream/datafiles:This PR avoids extracting files like this if they contain common joblib extensions and have a MIME type of
application/octet-stream.To avoid creating temporary directories (and also scanning the equivalent of "" if
tmpRootis not created), I tweakedprocessArchiveto return early if we detect these files. The nested extraction logic has also been updated to ignore joblib archives.