Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
tstromberg
suggested changes
Dec 19, 2024
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
egibs
commented
Dec 19, 2024
| "RiskScore": 4, | ||
| "RiskLevel": "CRITICAL" | ||
| }, | ||
| "/__min__c.~": { |
Member
Author
There was a problem hiding this comment.
Since UPX scans will result in two reports, we'll need to use JSON to maintain deterministic ordering.
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
Member
|
One concern I had was the possibility that Otherwise this PR LGTM. |
stevebeattie
approved these changes
Dec 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #197
Now that we've been encountering UPX binaries in packages, it makes sense to add support for scanning these files.
The main issue with this is that UPX has to be installed, but otherwise scanning is as easy as copying the file into our temporary scan directory and then running
upx -d.Before:
After:
Verification that we're not just decompressing the source file: