fix: Use baseVersion for SNAPSHOT path/URL resolution in FileSystemChecksumCalculator#1507
Merged
LogFlames merged 2 commits intoresolve_url_snapshotfrom Feb 24, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix path resolution using base version for SNAPSHOTs
fix: Use baseVersion for SNAPSHOT path/URL resolution in FileSystemChecksumCalculator
Feb 24, 2026
d182e2b to
bf3dff5
Compare
…tion Co-authored-by: algomaster99 <35191225+algomaster99@users.noreply.github.com>
245bb56 to
7f86c4a
Compare
LogFlames
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maven SNAPSHOT artifacts downloaded from remote repositories have a timestamped version (e.g.
1.0-20231010.123456-1) in their filename, but the local repository directory is named using the base version (1.0-SNAPSHOT). The old code usedgetVersion()for directory path/URL construction, causing lookups to fail for remotely-resolved SNAPSHOTs.Changes
FileSystemChecksumCalculator: Useartifact.getBaseVersion()instead ofartifact.getVersion()when constructing the remote repository URL path segment (directory uses base version; filename retains the timestamped version)LockFileFacade: UsepluginArtifact.getBaseVersion()for the directory segment when resolving the local POM path for SNAPSHOT pluginsFileSystemChecksumCalculatorTest: Unit tests covering both cases:baseVersionas directory (1.0-SNAPSHOT/my-artifact-1.0-20231010.123456-1.jar)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.