Skip to content

build: Add build-system to install project scripts #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smypmsa merged 1 commit into from
Oct 4, 2025
Merged

build: Add build-system to install project scripts #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ dev = [
[project.scripts]
pump_bot = "bot_runner:main"
Comment on lines 30 to 31
Copy link
Contributor

@coderabbitai coderabbitai bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Ensure bot_runner is included in the built distribution.

The console script points to bot_runner:main. If bot_runner.py is a top-level module (not inside a package), add py-modules so it’s packaged; if it’s inside a package, ensure package discovery includes it.

  • Option A (top-level bot_runner.py):
+[tool.setuptools]
+py-modules = ["bot_runner"]
  • Option B (package layout, e.g., pump_bot/ package):
+[tool.setuptools.packages.find]
+include = ["pump_bot*"]

Run this to verify presence and entry-point target before publishing wheels:

🏁 Script executed:

#!/bin/bash
# Verify the module exists and exposes main()
fd -a 'bot_runner.py' -E .venv -E venv
rg -nP '^\s*def\s+main\s*\(' -n --glob '!**/{.venv,venv,dist,build}/**' bot_runner.py || true

Length of output: 224

🏁 Script executed:

#!/bin/bash

# Inspect build-system in pyproject.toml
grep -n "\[build-system\]" pyproject.toml || true
sed -n '1,20p' pyproject.toml

# Check for build-backend and any tool.* sections
grep -n "build-backend" pyproject.toml || true
grep -n "^\[tool\." pyproject.toml || true

# Verify bot_runner.py location and main() definition
fd -a 'bot_runner.py' -E .venv -E venv
rg -nP '^\s*def\s+main\s*\(' -n src/bot_runner.py || true

# Show first 20 lines of bot_runner.py
echo "--- bot_runner.py (first 20 lines) ---"
head -n 20 src/bot_runner.py

Length of output: 1421

Configure setuptools to include your src modules and packages

Add the following to pyproject.toml so that bot_runner.py (and its dependencies in src/) are packaged and your console script entry point works:

[tool.setuptools]
package-dir = {"" = "src"}

[tool.setuptools.packages.find]
where = ["src"]
include = ["*"]

This will ensure bot_runner.py, config_loader.py, and your trading/utils packages are bundled in the wheel and available for the pump_bot = "bot_runner:main" script.

🤖 Prompt for AI Agents 
In pyproject.toml around lines 30-31, the project.scripts entry defines pump_bot
but setuptools isn't configured to package the source in src/, so bot_runner.py
and modules under src/ won't be included; add a [tool.setuptools] section with
package-dir = {"" = "src"} and a [tool.setuptools.packages.find] section with
where = ["src"] and include = ["*"] so that files under src/ (bot_runner.py,
config_loader.py and trading/utils packages) are discovered and bundled for the
console script entry point.


[build-system]
requires = ["setuptools>=61.0"]
build-backend = "setuptools.build_meta"

[tool.ruff]
exclude = [
".bzr",
Expand Down
Loading