Fix getLightClientProofByL1Height to use hex serialized alloy::U64#2544
Closed
Fix getLightClientProofByL1Height to use hex serialized alloy::U64#2544
Conversation
Copilot
AI
changed the title
[WIP]
Fix getLightClientProofByL1Height to use hex serialized alloy::U64
Jul 7, 2025
getLightClientProofByL1Height uses U64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getLightClientProofByL1HeightRPC method was using a regularu64parameter instead of hex-serializedalloy::U64, making it inconsistent with other RPC methods in the codebase and Ethereum JSON-RPC standards.Changes Made
alloy_primitives::U64import to the light client prover RPC modulel1_height: u64tol1_height: U64U64tou64using the.to()method when calling the database layerBefore
After
This change ensures the method follows the same pattern as other RPC methods like
get_sequencer_commitments_on_slot_by_number,get_verified_batch_proofs_by_slot_height, andget_l2_block_by_number, which all usealloy_primitives::U64for height parameters to provide proper JSON-RPC hex serialization (e.g.,"0x1a2b"instead of decimal6827).Fixes #2509.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.