Skip to content

Commit 3dbac45

Browse files
committed
OS#10368428: Under NTBUILD/Intl-WinGlob, failfast if IsExternalUnicodeLibraryAvailable would return false.
In NTBULID/Intl-WinGlob, the only caller (Js::CharClassifier::CharClassifier) will failfast when this method returns false, so move the failfast closer the cause of the problem to improve diagnosis and attribution by stack.
1 parent 756ee73 commit 3dbac45

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

lib/Runtime/PlatformAgnostic/Platform/Windows/UnicodeText.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -408,6 +408,18 @@ namespace PlatformAgnostic
408408
{
409409
return true;
410410
}
411+
#ifdef NTBUILD
412+
else
413+
{
414+
// did not find winGlobCharApi
415+
Js::Throw::FatalInternalError();
416+
}
417+
}
418+
else
419+
{
420+
// failed to initialize Windows Globalization
421+
Js::Throw::FatalInternalError();
422+
#endif
411423
}
412424

413425
return false;

0 commit comments

Comments
 (0)